[PATCH] D57316: [LoopSimplifyCFG] Use DT.update instead of DTU

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 6 11:45:25 PST 2019


kuhar added a comment.

In D57316#1386640 <https://reviews.llvm.org/D57316#1386640>, @mkazantsev wrote:

> I've given up using DTU, now the updates are applied directly.


Max, why don't you use DTU with `.applyUpdates`? Are you facing some difficulties, or found documentation confusing somewhere else?
I don't have much time recently, but I can definitely find enough to fix some issues people have with updating dominators. If you think something is not obvious or too difficult, there are probably multiple people who faced the same problems but never bother to share their experience.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57316/new/

https://reviews.llvm.org/D57316





More information about the llvm-commits mailing list