[PATCH] D56842: [llvm-objdump] - Move getRelocationValueString and dependenices out of the llvm-objdump.cpp

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 17 17:24:16 PST 2019


sbc100 added inline comments.


================
Comment at: tools/llvm-objdump/WasmDump.cpp:53
+  return std::error_code();
+}
----------------
Missing newline at EOF


================
Comment at: tools/llvm-objdump/llvm-objdump.h:139
+                              const object::RelocationRef &RelRef,
+                              llvm::SmallVectorImpl<char> &Result);
+
----------------
Why not continue to use overloads?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56842/new/

https://reviews.llvm.org/D56842





More information about the llvm-commits mailing list