[PATCH] D56842: [llvm-objdump] - Move getRelocationValueString and dependenices out of the llvm-objdump.cpp

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 17 05:02:45 PST 2019


grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: tools/llvm-objdump/llvm-objdump.h:74
+
+class SectionFilterIterator {
+public:
----------------
jhenderson wrote:
> This is probably fine as is, but I wonder if it actually belongs in the Object library?
I would be happy to not have it here. But I think we need to find more users for this to move it out first? Until it is proved to be useful outside of `llvm-objdump`, I would keep it here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56842/new/

https://reviews.llvm.org/D56842





More information about the llvm-commits mailing list