[PATCH] D56749: [NFC] Make pgo related options in opt more consistent.

Rong Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 15 16:08:44 PST 2019


xur accepted this revision.
xur added a comment.
This revision is now accepted and ready to land.

This cleanup looks good to me.



================
Comment at: tools/opt/opt.cpp:274
 
+enum PGOKind { NoPGO, InstrGen, InstrUse, SampleUse };
+cl::opt<PGOKind>
----------------
can we move this enum to header so that we won't duplicate in NewPMDriver.cpp?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56749/new/

https://reviews.llvm.org/D56749





More information about the llvm-commits mailing list