[PATCH] D56749: [NFC] Make pgo related options in opt more consistent.

[Wei Mi via Phabricator via llvm-commits]

wmi created this revision.
wmi added reviewers: tejohnson, xur.
Herald added subscribers: eraman, mehdi_amini.

Currently we have pgo options defined in PassManagerBuilder.cpp only for instrument pgo, but not for sample pgo. We also have pgo options defined in NewPMDriver.cpp in opt only for new pass manager and for all kinds of pgo. They have some inconsistency.

To make the options more consistent and make tests writing easier,  the patch let old pass manager to share the same pgo options with new pass manager in opt, and removes the options in PassManagerBuilder.cpp.


Repository:
  rL LLVM

https://reviews.llvm.org/D56749

Files:
  lib/Transforms/IPO/PassManagerBuilder.cpp
  test/Other/new-pm-pgo.ll
  test/Transforms/PGOProfile/preinline.ll
  test/Transforms/SampleProfile/function_metadata.ll
  tools/opt/NewPMDriver.cpp
  tools/opt/opt.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56749.181895.patch
Type: text/x-patch
Size: 8324 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190115/5cc1fce1/attachment.bin>