[PATCH] D55629: [elfabi] Add support for reading DT_SONAME from binaries

Armando Montanez via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 15 11:37:56 PST 2019


amontanez updated this revision to Diff 181830.
amontanez marked an inline comment as done.
amontanez edited the summary of this revision.
amontanez added a comment.

using reinterpret_cast now. Since it looks like it might take a bit of time to land support for dynamic entries in yaml2obj, do you feel it would be fine to land this patch now and update the tests later?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55629/new/

https://reviews.llvm.org/D55629

Files:
  llvm/test/tools/llvm-elfabi/binary-read-add-soname.test
  llvm/test/tools/llvm-elfabi/binary-read-arch.test
  llvm/test/tools/llvm-elfabi/binary-read-bad-soname.test
  llvm/test/tools/llvm-elfabi/binary-read-bad-vaddr.test
  llvm/test/tools/llvm-elfabi/binary-read-no-dt-strsz.test
  llvm/test/tools/llvm-elfabi/binary-read-no-dt-strtab.test
  llvm/test/tools/llvm-elfabi/binary-read-no-dynamic.test
  llvm/test/tools/llvm-elfabi/binary-read-replace-soname.test
  llvm/test/tools/llvm-elfabi/binary-read-soname-no-null.test
  llvm/test/tools/llvm-elfabi/binary-read-soname.test
  llvm/test/tools/llvm-elfabi/replace-soname-tbe.test
  llvm/tools/llvm-elfabi/ELFObjHandler.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55629.181830.patch
Type: text/x-patch
Size: 20353 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190115/8ee46437/attachment.bin>


More information about the llvm-commits mailing list