[PATCH] D55629: [elfabi] Add support for reading DT_SONAME from binaries

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM, aside from one small comment.



================
Comment at: llvm/tools/llvm-elfabi/ELFObjHandler.cpp:151
 
+  StringRef DynStr((const char *)DynStrPtr.get(), DynEnt.StrSize);
+
----------------
I was under the impression that C++ style casts were preferred, but I could be wrong. I also don't see a good reason to change it from what was there before (i.e. reinterpret_cast).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55629/new/

https://reviews.llvm.org/D55629