[PATCH] D56628: gn build: Add build files for compiler-rt/lib/{hwasan,interception,sanitizer_common,ubsan}.

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: llvm/utils/gn/secondary/compiler-rt/lib/hwasan/BUILD.gn:31
+
+source_set("sources") {
+  sources = [
----------------
thakis wrote:
> This is the first source_set :-) I went with static_library almost everywhere because
> 
> - llvm-config expects the presence of many of the llvm libs
> - the chromium build used source_sets pervasively at first but that was bad for binary size and link time, so many of that had to be undone
> 
> If you think source_set is the thing to do here it's fine to keep this as-is, just wanted to mention it.
CMake build uses object libraries, which is GN source set equivalent, for various targets in runtimes, typically to share objects between static and shared libraries, and those use cases are exactly what source sets are intended for so this is IMO fine.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56628/new/

https://reviews.llvm.org/D56628