[PATCH] D56628: gn build: Add build files for compiler-rt/lib/{hwasan, interception, sanitizer_common, ubsan}.

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 11 20:28:11 PST 2019


phosek added inline comments.


================
Comment at: llvm/utils/gn/secondary/compiler-rt/lib/ubsan/BUILD.gn:1
+source_set("sources") {
+  sources = [
----------------
How closely do we want to follow CMake target names? For example, in CMake build this target is called `RTUbsan` (`add_compiler_rt_object_libraries` also adds `.<arch>` but that's an implementation detail).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56628/new/

https://reviews.llvm.org/D56628





More information about the llvm-commits mailing list