[llvm] r350854 - [lit] Make it possible for the lit test suite to pass with

[Joel E. Denny via llvm-commits]

On Thu, Jan 10, 2019 at 12:51 PM Dan Liew via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: delcypher
> Date: Thu Jan 10 09:47:44 2019
> New Revision: 350854
>
> URL: http://llvm.org/viewvc/llvm-project?rev=350854&view=rev
> Log:
> [lit] Make it possible for the lit test suite to pass with
> `FILECHECK_OPTS=-v` set in the environment.
>
> Follow up to r350850 as requested by Joel E. Denny in
> https://reviews.llvm.org/D56541 .
>
> Modified:
>     llvm/trunk/utils/lit/tests/shtest-run-at-line.py
>
> Modified: llvm/trunk/utils/lit/tests/shtest-run-at-line.py
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/tests/shtest-run-at-line.py?rev=350854&r1=350853&r2=350854&view=diff
>
> ==============================================================================
> --- llvm/trunk/utils/lit/tests/shtest-run-at-line.py (original)
> +++ llvm/trunk/utils/lit/tests/shtest-run-at-line.py Thu Jan 10 09:47:44
> 2019
> @@ -1,7 +1,7 @@
>  # Check that -vv makes the line number of the failing RUN command clear.
>  # (-v is actually sufficient in the case of the internal shell.)
>  #
> -# RUN: not %{lit} -j 1 -vv %{inputs}/shtest-run-at-line > %t.out
> +# RUN: env -u FILECHECK_OPTS not %{lit} -j 1 -vv
> %{inputs}/shtest-run-at-line > %t.out
>  # RUN: FileCheck --input-file %t.out %s
>  #
>  # END.
>

I assumed this would be more general like D56541.  No problem if it works.
I just want to understand any issue for when we return to this later.

Thanks.

Joel


>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190110/4b728f37/attachment.html>