<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Jan 10, 2019 at 12:51 PM Dan Liew via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: delcypher<br>
Date: Thu Jan 10 09:47:44 2019<br>
New Revision: 350854<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=350854&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=350854&view=rev</a><br>
Log:<br>
[lit] Make it possible for the lit test suite to pass with<br>
`FILECHECK_OPTS=-v` set in the environment.<br>
<br>
Follow up to r350850 as requested by Joel E. Denny in<br>
<a href="https://reviews.llvm.org/D56541" rel="noreferrer" target="_blank">https://reviews.llvm.org/D56541</a> .<br>
<br>
Modified:<br>
llvm/trunk/utils/lit/tests/shtest-run-at-line.py<br>
<br>
Modified: llvm/trunk/utils/lit/tests/shtest-run-at-line.py<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/tests/shtest-run-at-line.py?rev=350854&r1=350853&r2=350854&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/tests/shtest-run-at-line.py?rev=350854&r1=350853&r2=350854&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/utils/lit/tests/shtest-run-at-line.py (original)<br>
+++ llvm/trunk/utils/lit/tests/shtest-run-at-line.py Thu Jan 10 09:47:44 2019<br>
@@ -1,7 +1,7 @@<br>
# Check that -vv makes the line number of the failing RUN command clear.<br>
# (-v is actually sufficient in the case of the internal shell.)<br>
#<br>
-# RUN: not %{lit} -j 1 -vv %{inputs}/shtest-run-at-line > %t.out<br>
+# RUN: env -u FILECHECK_OPTS not %{lit} -j 1 -vv %{inputs}/shtest-run-at-line > %t.out<br>
# RUN: FileCheck --input-file %t.out %s<br>
#<br>
# END.<br></blockquote><div><br></div><div>I assumed this would be more general like D56541. No problem if it works. I just want to understand any issue for when we return to this later.<br></div><div><br></div><div>Thanks.</div><div><br></div><div>Joel<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div>