[PATCH] D53906: [ARM][AArch64] Increase TLS alignment to reserve space for Android's TCB

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 8 14:56:23 PST 2019


ruiu added a comment.

LGTM



================
Comment at: ELF/Writer.cpp:2190
+        // This reservation is needed for backwards compatibility with Android's
+        // TCB, but for simplicity it is also done on other operating systems.
+        P->p_align = std::max<uint64_t>(P->p_align, Config->Wordsize * 8);
----------------
Perhaps it is good to leave a comment as to why this is !Config->Shared only.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53906/new/

https://reviews.llvm.org/D53906





More information about the llvm-commits mailing list