[PATCH] D55874: [asan] Support running without /proc.

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/asan/asan_thread.cc:302
+    GetThreadStackAndTls(tid() == 0, const_cast<uptr *>(&stack_bottom_),
+                         const_cast<uptr *>(&stack_size), &tls_begin_,
+                         &tls_size);
----------------
I dont see why const_cast is needed here


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_procmaps_common.cc:147
 
+bool MemoryMappingLayout::IsAvailable(bool cache_enabled) {
+  if (cache_enabled && cached_proc_self_maps.data)
----------------
what is the purpose of cache_enabled?
It's always true
also to return false, it needs to always get to IsProcMapsAvailable()


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55874/new/

https://reviews.llvm.org/D55874