[PATCH] D55874: [asan] Support running without /proc.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 18 20:35:45 PST 2018


pcc added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_posix.h:106
 
+bool MaybeFailToOpen(const char *path);
+
----------------
The purpose of this function is a little ambiguous from the name, it sounds like it might actually try to open the file. Maybe a better name would be `ShouldMockFailureToOpen`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55874/new/

https://reviews.llvm.org/D55874





More information about the llvm-commits mailing list