[PATCH] D54780: [llvm-demangle-fuzzer] Also fuzz microsoftDemangle().

Erik Pilkington via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 14 10:54:26 PST 2018


erik.pilkington added a comment.

In D54780#1331426 <https://reviews.llvm.org/D54780#1331426>, @thakis wrote:

> I believe this runs on oss-fuzz already: https://github.com/google/oss-fuzz/blob/master/projects/llvm/build.sh#L37


Oh, okay nice. Thanks for checking.

> Having one or two fuzzer binaries seems like a toss-up (true it's a mostly independent branch, but we don't create a new fuzzer binary for each independent branch), and having just binary saves the work of hooking a new binary up on oss-fuzz.

I would probably prefer always calling microsoftDemangle() in llvm-demangler-fuzzer. The Itanium demanglers are identical, so we're just wasting cycles fuzzing them both independently.

> Re corpus: I'd be very surprised if oss-fuzzer assumed that fuzzers never change. So I don't think (but don't know for sure) that this is a concern.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54780/new/

https://reviews.llvm.org/D54780





More information about the llvm-commits mailing list