[PATCH] D54762: i686 mingw-w64 comdat functions use wrong .text section name

Andrew Yohn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 25 11:14:01 PST 2018


herman6067 added a comment.

In D54762#1305765 <https://reviews.llvm.org/D54762#1305765>, @rnk wrote:

> I never could reproduce the linker error either. =/ I can easily check the section name that GCC uses, but using the wrong section names doesn't seem to cause any problems, so I didn't prioritize fixing this. Anyway, better to match behavior when it's otherwise inconsequential.


I was able to create the linker error using gcc 8.1.0 from mingw-builds.org. I've rebuilt clang with these changes and it seems to be working well now. Thank you very much!


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54762/new/

https://reviews.llvm.org/D54762





More information about the llvm-commits mailing list