[PATCH] D54762: i686 mingw-w64 comdat functions use wrong .text section name

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 21 14:05:11 PST 2018


rnk added a comment.

In https://reviews.llvm.org/D54762#1305746, @mstorsjo wrote:

> LGTM - this looks sensible to me. I haven't verified the original issue and whether this fixes it, but the change itself looks good.


I never could reproduce the linker error either. =/ I can easily check the section name that GCC uses, but using the wrong section names doesn't seem to cause any problems, so I didn't prioritize fixing this. Anyway, better to match behavior when it's otherwise inconsequential.


Repository:
  rL LLVM

https://reviews.llvm.org/D54762





More information about the llvm-commits mailing list