[PATCH] D54663: [PowerPC] Complete the custom legalization of vector int to fp conversion

[Jinsong Ji via Phabricator via llvm-commits]

jsji added inline comments.


================
Comment at: test/CodeGen/PowerPC/vec_conv_i16_to_fp32_elts.ll:83
 ; CHECK-P8:       # %bb.0: # %entry
+; CHECK-P8-NEXT:    addis r4, r2, .LCPI1_0 at toc@ha
 ; CHECK-P8-NEXT:    mtvsrd f0, r3
----------------
nemanjai wrote:
> jsji wrote:
> > Shall we check the data in .LCPI1_0 to make sure the permute control is correct?
> I think that doing it for all of them would be time consuming without a particularly good justification. Furthermore, these check patterns were produced by the script so if anyone updates anything about the codegen in the future and re-runs the script, those checks would be lost. Perhaps I could do it for one only, but that seems rather arbitrary.
> 
> If you insist, I'll certainly add it.
Make sense, that is fine, I'm OK with skipping them . Thanks.


Repository:
  rL LLVM

https://reviews.llvm.org/D54663