[PATCH] D54337: [ASan] Make AddressSanitizer a ModulePass

[Philip Pfaffe via Phabricator via llvm-commits]

philip.pfaffe added a comment.

> Hmm... can you point me where function definitions are being added in doInitialization, I just dont see it (frankly I'm not familiar with this code at all).

I might have been wrong here, I assumed the Asan function pass did this,too, because all sanitizers I've looked at do it. But it's possible that only the Module variant does it.

> I dont see why do you prefer the latter, adding function definitions in module passes seems to be quite normal, and then it will definitely solve the problem with opt.

I'm against a module pass because it implies inter-pass-dependencies. If you run the function pass but not the module pass, you end up with a broken program. I'd really like to avoid that.


Repository:
  rL LLVM

https://reviews.llvm.org/D54337