[PATCH] D54337: [ASan] Make AddressSanitizer a ModulePass

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev added a comment.

In https://reviews.llvm.org/D54337#1294149, @philip.pfaffe wrote:

> The problem is not speed but correctness. The initialization adds function definitions, which function passes can't do.


Hmm... can you point me where function definitions are being added in doInitialization, I just dont see it (frankly I'm not familiar with this code at all).

> So we need to initialize out-of-band, either with a separate module pass, or some function outside of the pass pipeline. I strongly prefer the latter, but it's not entirely clear to me how this function should be called. It's obviousl when running this through clang, but what about opt?

I dont see why do you prefer the latter, adding function definitions in module passes seems to be quite normal, and then it will definitely solve the problem with opt.


Repository:
  rL LLVM

https://reviews.llvm.org/D54337