[PATCH] D53889: [CodeGen] Prefer static frame index for STATEPOINT liveness args

Nirav Dave via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 9 08:19:20 PST 2018


niravd added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/StatepointLowering.cpp:527
+    // If the argument is a static frame index, use it without spilling.
+    if (isa<AllocaInst>(V) ||
+        (isa<Argument>(V) &&
----------------
Can we fold this into getValue/getValueImpl? IIUC, this is a reasonable expectation for getValue for these inputs and it'd be nicer 
there. I haven't checked, but I think it must be the case that all possible matches are always non-register values in any context we encounter them so there's no reason for getValue to be otherwise defined.





Repository:
  rL LLVM

https://reviews.llvm.org/D53889





More information about the llvm-commits mailing list