[PATCH] D53889: [CodeGen] Prefer static frame index for STATEPOINT liveness args

[Cherry Zhang via Phabricator via llvm-commits]

cherry added a comment.

Thanks for the review!



================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:1383
+    int FI = FuncInfo.getArgumentFrameIndex(Arg);
+    if (FI != INT_MAX)
+      return DAG.getFrameIndex(FI, TLI.getFrameIndexTy(DAG.getDataLayout()));
----------------
anna wrote:
> is this just being conservative against a corner case?
INT_MAX is a sentinel value that getArgumentFrameIndex returns meaning "no". Other uses of getArgumentFrameIndex have similar checks.



Repository:
  rL LLVM

https://reviews.llvm.org/D53889