[PATCH] D53710: [FileCheck] Warn if a prefix is only used in LABEL checks

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added a comment.

Agreed with all previous comments! And yes, I messed up my last lit test example :-( and I looked at yours and Paul's, and agree. But anyway, we have a plan...

But perhaps one more quick discussion on this:

> 1. Put the current diagnostic under an off-by-default option

and:

> Should off-by-default diagnostics be errors instead of warnings?

What do you think about this: we don't put it under an option, and kind of leave it as it is? This means:

- you don't see warnings (including this one) when you e.g. do a `ninja check`
- you don't see warnings when you do e.g. `llvm-lit` on a test.
- I think you'll only see it when you enable `llvm-lit -v` (or `llvm -a` which I always use when I develop new tests).

Thus, I think it is already under and option, which is not enabled by default. I appreciate I might be asking the same question again, but just wanted to double check what you think. The reason I am asking, is that I am afraid that when we put this under a new, separate option (if I understood correctly), people won't use it, and there's perhaps little benefit of having it?


https://reviews.llvm.org/D53710