[PATCH] D53710: [FileCheck] Warn if a prefix is only used in LABEL checks

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In https://reviews.llvm.org/D53710#1291939, @probinson wrote:

>   we can't reliably report all typos.


Agreed.

> Staying out of the 'dodgy' and 'broken' terminology debate,

:-)  Sorry for that.  My goal really was just to be sure we were discussing the same thing.

> To summarize, then:
> 
> 1. Put the current diagnostic under an off-by-default option.
> 2. In a follow-up patch, emit a diagnostic for any prefix that has no matches (even if other prefixes do have matches). This might require fixing some tests, or it will need to be off-by-default while we do test cleanup.
> 3. Ignore the RFC and rename LABEL to BOUND ideas.

I think this plan makes a lot of sense.

Should off-by-default diagnostics be errors instead of warnings?  Errors are harder to miss, and, if they're off-by-default, they're probably harmless.  Alternatively, we could start developing flags like -Wfoo, -Wbar, -Wall, -Werror, etc.


https://reviews.llvm.org/D53710