[PATCH] D54211: [SimpleLoopUnswitch] partial unswitch needs to be careful when replacing invariants with constants

Wed Nov 7 11:37:00 PST 2018

fedor.sergeev added a comment.

In https://reviews.llvm.org/D54211#1290438, @chandlerc wrote:

> In https://reviews.llvm.org/D54211#1290435, @chandlerc wrote:
>
> > Could you not introduce all the separate test files?
>
>
> I was trying to much more genuinely ask "is there a problem with doing this that I'm not seeing?" not being rhetorical or hyperbolic.

No prob :) I tend to be rather direct in such cases myself, sometimes getting into the trouble...

Honestly, I first did my tests and then figured out that original nontrivial tests do catch 'AND' case.
So yes, with my addition of 'OR' case there in test27 I can freely dump new nontrivial-unswitch test.
And as I have just discovered trivial-unswitch version is covered by existing trivial-unswitch.ll test.

So I'll keep the change in existing tests and dump the new ones.

Repository:
  rL LLVM

https://reviews.llvm.org/D54211