[PATCH] D54211: [SimpleLoopUnswitch] partial unswitch needs to be careful when replacing invariants with constants

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added a comment.

In https://reviews.llvm.org/D54211#1290435, @chandlerc wrote:

> Could you not introduce all the separate test files?


I was editting this comemnt and end up editting it into something that reads passive aggressively and not very politely. Really sorry about that, it was not at all my intention.

I was trying to much more genuinely ask "is there a problem with doing this that I'm not seeing?" not being rhetorical or hyperbolic.

Anyways, just felt bad on re-reading my comment and seeing that it ended up very different from my intent / mental process.


Repository:
  rL LLVM

https://reviews.llvm.org/D54211