[PATCH] D54192: [ARM] Fix CPSR liveness in tMOVCCr_pseudo lowering.

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 7 05:22:03 PST 2018


SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

Looks very reasonable to me.



================
Comment at: test/CodeGen/ARM/wide-compares.ll:130
+define i64 @test_slt_select(i64 %c, i64 %d, i64 %a, i64 %b) {
+; CHECK-ARM-LABEL: test_slt_select:
+; CHECK-ARM:       @ %bb.0: @ %entry
----------------
My first impression of the tests was that they could benefit from a bit of a clean-up (stack offsets, register usage, asm comments, etc.). But looks like there are 2 schools of thoughts on this. One of them being that the output of the script is okay because it is explicit, shows everything, etc. So yeah, please ignore, whatever you think is appropriate. 


Repository:
  rL LLVM

https://reviews.llvm.org/D54192





More information about the llvm-commits mailing list