[PATCH] D46061: [DEBUGINFO, NVPTX] Disable emission of ',debug' option if only debug directives are allowed.

[Alexey Bataev via llvm-commits]

No, I reworked the patch according to his advice, so I assume everything is fine here
-------------
Best regards,
Alexey Bataev

02.11.2018 10:50, David Blaikie пишет:
Looks like Eric still had some questions here? Or at least hadn't commented about whether the answers/changes addressed his concerns?

On Thu, Nov 1, 2018 at 12:45 PM Paul Robinson via Phabricator <reviews at reviews.llvm.org<mailto:reviews at reviews.llvm.org>> wrote:
probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: test/DebugInfo/NVPTX/debug-file-loc-only.ll:3
+
+; // Bitcode int this test case is reduced version of compiled code below:
+;extern "C" {
----------------
Typo: "Bitcode in this test..." (not "int").



Repository:
  rL LLVM

https://reviews.llvm.org/D46061




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181102/883855d2/attachment.html>