<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<pre class="moz-signature" cols="72">No, I reworked the patch according to his advice, so I assume everything is fine here
-------------
Best regards,
Alexey Bataev</pre>
<div class="moz-cite-prefix">02.11.2018 10:50, David Blaikie пишет:<br>
</div>
<blockquote type="cite" cite="mid:CAENS6EtFjYgOXj5p_0B0dS_qv3cZfmQHWDm2b-J_reOystdHfQ@mail.gmail.com">
<div dir="ltr">Looks like Eric still had some questions here? Or at least hadn't commented about whether the answers/changes addressed his concerns?<br>
<br>
<div class="gmail_quote">
<div dir="ltr">On Thu, Nov 1, 2018 at 12:45 PM Paul Robinson via Phabricator <<a href="mailto:reviews@reviews.llvm.org" moz-do-not-send="true">reviews@reviews.llvm.org</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
probinson accepted this revision.<br>
probinson added a comment.<br>
This revision is now accepted and ready to land.<br>
<br>
LGTM<br>
<br>
<br>
<br>
================<br>
Comment at: test/DebugInfo/NVPTX/debug-file-loc-only.ll:3<br>
+<br>
+; // Bitcode int this test case is reduced version of compiled code below:<br>
+;extern "C" {<br>
----------------<br>
Typo: "Bitcode in this test..." (not "int").<br>
<br>
<br>
<br>
Repository:<br>
rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D46061" rel="noreferrer" target="_blank" moz-do-not-send="true">https://reviews.llvm.org/D46061</a><br>
<br>
<br>
<br>
</blockquote>
</div>
</div>
</blockquote>
<br>
</body>
</html>