[PATCH] D53390: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG.

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 31 13:49:12 PDT 2018


vsk added inline comments.


================
Comment at: lib/Transforms/Utils/SimplifyCFG.cpp:1379
+  Instruction *InsertPt = BIParent->size() > 1
+                              ? BIParent->getTerminator()->getPrevNode()
+                              : BIParent->getTerminator();
----------------
A bit nitty-gritty, but: Can the instruction before the terminator be a debug info intrinsic?

If so, I think the line location you pick be different if you switch from -gline-tables-only versus -g.


https://reviews.llvm.org/D53390





More information about the llvm-commits mailing list