[PATCH] D53538: NFC: Reorganize the demangler a bit

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 29 06:19:31 PDT 2018


labath added a comment.

I like this change a lot. I was hoping something like this could be done, when I saw that we were copying patches around.

(Not clicking accept as I don't feel like an owner here.)



================
Comment at: libcxxabi/src/demangle/README.txt:51
+
+I also highly recommend running libFuzzer after non-trivial changes, see
+libcxxabi/fuzz/cxa_demangle_fuzzer.cpp and https://llvm.org/docs/LibFuzzer.html.
----------------
Use an impersonal form here? "It is also highly recommended...", or at least change "I" to "we".


https://reviews.llvm.org/D53538





More information about the llvm-commits mailing list