[PATCH] D53379: GSYM symbolication format

[Zachary Turner via llvm-commits]

Oh I usually would store a BinaryStreamRef in the class and just create the
BinaryStreamReader on the stack whenever you need one
On Sat, Oct 27, 2018 at 6:59 AM Greg Clayton via Phabricator <
reviews at reviews.llvm.org> wrote:

> clayborg added inline comments.
>
>
> ================
> Comment at: include/llvm/DebugInfo/GSYM/GsymReader.h:119
> +  std::unique_ptr<MemoryBuffer> MemBuffer;
> +  mutable BinaryStreamReader GSYMData;
> +  const Header *GSYMHeader = nullptr;
> ----------------
> zturner wrote:
> > Why does this need to be mutable?
> because BinaryStreamReader must use BinaryStreamReader::setOffset() before
> reading data because it contains the file position. Many functions should
> be const, but they can't be if they access any data in GSYMData.
>
>
> https://reviews.llvm.org/D53379
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181027/97726bae/attachment.html>