[PATCH] D53349: [VPlan] Changes to implement VPlan based predication for VPlan-native path.

[Satish K Guggilla via Phabricator via llvm-commits]

sguggill marked 12 inline comments as done.
sguggill added inline comments.


================
Comment at: lib/Transforms/Vectorize/VPlanPredicator.cpp:29
+// Count PredBlock's successors, skipping back-edges
+int VPlanPredicator::countSuccessorsNoBE(VPBlockBase *PredBlock, bool &HasBE) {
+  HasBE = false;
----------------
fhahn wrote:
> personally I think it would be slightly clearer to have this function return a pair<int, bool>.
> 
> Also, the only state from VPlanPredicator used seems to be VPLI. Maybe this could just be a static non-member function?
We are not using HasBE currently. I have removed it for now. I also moved this function to VPBlockUtils.


================
Comment at: lib/Transforms/Vectorize/VPlanValue.h:42
   friend class VPlanHCFGTransforms;
+  friend class VPlanPredicator;
   friend class VPBasicBlock;
----------------
fhahn wrote:
> I think I missed which private things are used in VPlanPredicator?
Yes, this is not needed right now. I have removed it. Thanks for catching this.


Repository:
  rL LLVM

https://reviews.llvm.org/D53349