[PATCH] D53349: [VPlan] Changes to implement VPlan based predication for VPlan-native path.

[Satish K Guggilla via Phabricator via llvm-commits]

sguggill added inline comments.


================
Comment at: lib/Transforms/Vectorize/LoopVectorizationLegality.cpp:26
 
+extern cl::opt<bool> EnableVPlanPredication;
+
----------------
fhahn wrote:
> Would it be possible to avoid adding a EnableVPlanPredication option? IIUC, we would always like to run predication, if it is required?
> 
> I think it would be good to avoid adding too many options, to ensure we get good test coverage for all parts. Or make the default true.
Yes, I will remove this switch once we have divergence analysis. Right now when predication is enabled, we suppress the check for trivially uniform non-backedge branches and assume they are divergent. Without this check, the CG tests added testing uniform control flow will fail. I understand the concern about adding too many options and will add a FIXME comment about the same.


Repository:
  rL LLVM

https://reviews.llvm.org/D53349