[PATCH] D53160: AMDGPU: Avoid selecting ds_{read,write}2_b32 on SI

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 16 11:33:15 PDT 2018


nhaehnle updated this revision to Diff 169870.
nhaehnle added a comment.

Right, I looked at SelectDS64Bit4ByteAligned, but doing the split there
requires more code and also seems wrong since it'd mean inserting
additional nodes fairly late without giving them a chance to be combined
(not that they'd be combined very often, but still).

In a sense, splitting the vectorized load is a form of legalization.

Anyway, removing the FIXME comment.


Repository:
  rL LLVM

https://reviews.llvm.org/D53160

Files:
  lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
  lib/Target/AMDGPU/SIISelLowering.cpp
  test/CodeGen/AMDGPU/lds-bounds.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53160.169870.patch
Type: text/x-patch
Size: 6571 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181016/11a863f7/attachment.bin>


More information about the llvm-commits mailing list