[PATCH] D53291: add riscv32e to the llvm

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 15 20:11:47 PDT 2018


asb added a comment.

Hi Daliang and welcome to the LLVM community.

Many thanks for your work on RV32E support. In our discussion on the sw-dev mailing list I suggested <https://groups.google.com/a/groups.riscv.org/d/msg/sw-dev/EEd3xSUXcfg/DgeswrTMFQAJ> splitting this task into the MC layer, calling convention, and codegen support. I'd recommend preparing patches in a way that does this. Each of these elements should come along with tests.

You shouldn't need to have riscv32e as a new triple. Just rely on the SubtargetFeature - this should remove a lot of code from this patch.


Repository:
  rL LLVM

https://reviews.llvm.org/D53291





More information about the llvm-commits mailing list