[PATCH] D53245: Teach the DominatorTree fallback to recalculation when applying updates to speedup JT (PR37929)

[Brian Rzycki via Phabricator via llvm-commits]

brzycki added a comment.

Ii might also be worth investigating to make these constant hidden command line parameters. For one it makes testing faster and it also gives users an emergency knob (the `cl::opt()` mechanism).



================
Comment at: include/llvm/Support/GenericDomTreeConstruction.h:1198
+    // size of the DominatorTree. The constant is selected
+    // by choosing the one with the best performance on some real-world inputs.
+    if (NumLegalized > DT.DomTreeNodes.size() / 75)
----------------
I think this comment is still too vague. It doesn't need to be altered until the final algorithm is selected but I'd like to see more details here. Seemingly arbitrary constants needs support information more than "trust me, I ran some tests".


https://reviews.llvm.org/D53245