[PATCH] D53126: [X86] Restore X86ISelDAGToDAG::matchBEXTRFromAnd. Teach address matching to create a BEXTR pattern from a (shl (and X, mask >> C1) if C1 can be folded into addressing mode.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 10 23:35:04 PDT 2018


lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

This does not have the regressions https://reviews.llvm.org/D53080 has, so i guess this is good :)
Most likely do wait for @RKSimon though.



================
Comment at: test/CodeGen/X86/tbm_patterns.ll:57
+; CHECK-NEXT:    shrl $4, %edi
+; CHECK-NEXT:    testl $4095, %edi # imm = 0xFFF
 ; CHECK-NEXT:    cmovnel %edx, %eax
----------------
These reverted/regressed back.


Repository:
  rL LLVM

https://reviews.llvm.org/D53126





More information about the llvm-commits mailing list