[PATCH] D52933: Fix incorrect Twine usage in CFGPrinter

Kristina Brooks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 7 11:20:55 PDT 2018


kristina added a comment.

In https://reviews.llvm.org/D52933#1257372, @grosser wrote:

> Thanks Marcin for improving the commit message. We all seem to agree that this is the right correction. Hence, I feel this is ready to upstream from my side. As there have been quite some opinions, it would be great to hear if there are any open concerns that should be adressed or if others also feel this LGT(them). We especially still need feedback from @kristina!
>
> As a minor remark. I would drop the comment about the twine stuff. We cannot have these comments spread all over the code base. Having this documented in the commit message seems sufficient from my perspective.


Also agree on that point, the fix is good but it's probably best to drop the comment itself, if anything, documentation should likely be updated to **clearly** label such behavior as undefined as a followup.


Repository:
  rL LLVM

https://reviews.llvm.org/D52933





More information about the llvm-commits mailing list