[PATCH] D52933: Fix incorrect Twine usage in CFGPrinter

Kristina Brooks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 7 11:03:53 PDT 2018


kristina accepted this revision.
kristina added a comment.
This revision is now accepted and ready to land.

My bad, I must have misunderstood the inner workings of `Twine`. I was under the impression that it would end up holding a reference in the RHS object since all of them were just constructed and Twine objects chain together. I know they're unsafe to store anywhere aside from the stack but I didn't realize this behavior was UB. My apologies.


Repository:
  rL LLVM

https://reviews.llvm.org/D52933





More information about the llvm-commits mailing list