[PATCH] D43515: More math intrinsics for conservative math handling

[Cameron McInally via Phabricator via llvm-commits]

cameron.mcinally added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:7330
+    break;
+  }
+
----------------
kpn wrote:
> cameron.mcinally wrote:
> > There are a lot of comments on this, so I may have missed something. Take with a grain of salt...
> > 
> > I don't think these are correct. These can trap so can't be speculatively executed. They would need a chain.
> I couldn't figure out how to have these be chained but have the non-strict continue to not be chained. Too many things fell over if they didn't match.
I'm not an expert with this code, so cc @andrew.w.kaylor. 

This doesn't seem like the right direction though. Maybe these unchained operations should be left to a different patch until a proper solution is found.


https://reviews.llvm.org/D43515