[PATCH] D43515: More math intrinsics for conservative math handling

[Kevin P. Neal via Phabricator via llvm-commits]

kpn added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:7330
+    break;
+  }
+
----------------
cameron.mcinally wrote:
> There are a lot of comments on this, so I may have missed something. Take with a grain of salt...
> 
> I don't think these are correct. These can trap so can't be speculatively executed. They would need a chain.
I couldn't figure out how to have these be chained but have the non-strict continue to not be chained. Too many things fell over if they didn't match.


https://reviews.llvm.org/D43515