[PATCH] D52680: Add comments explaning variables in action table generation (NFC)

Rink via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 3 02:41:16 PDT 2018


zhmu added a comment.

While I thank you for your efforts, I really think this is a bad idea:

- If a comment is necessary to illustrate the point of a variable name, this means the variable name is wrong and we ought to change it
- Such comments tend to get outdated as no one reads/updates them anymore once the code is reworked

In this case, I'd say the variable names aren't that strange or need explanation in this degree. Perhaps the overall flow can be improved, but that is beyond the scope of simply adding a comment.


Repository:
  rL LLVM

https://reviews.llvm.org/D52680





More information about the llvm-commits mailing list