[PATCH] D52680: Add comments explaning variables in action table generation (NFC)

Rink via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 3 02:39:35 PDT 2018


zhmu added a comment.

While I thank you for your efforts, I really think this is a bad idea:

- If a comment is necessary to illustrate the point of a variable name, this means the variable name is wrong and we ought to change it
- In this case, I'd say the variable names aren't that strange or need explanation




Repository:
  rL LLVM

https://reviews.llvm.org/D52680





More information about the llvm-commits mailing list