[PATCH] D52680: Add comments explaning variables in action table generation (NFC)

Kristina Brooks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 28 20:52:50 PDT 2018


kristina added a reviewer: kristina.
kristina added a comment.

IMO these comments don't really provide anything that isn't clear from names of the variables ie. `SizeTypeID: size of typeid (usually 1)`. In fact statements like "usually 1" provide more ambiguity as opposed to clarifying anything. Same goes for `SizeActions: size of all action entries for a function`, the variable names are descriptive enough.


Repository:
  rL LLVM

https://reviews.llvm.org/D52680





More information about the llvm-commits mailing list