[PATCH] D52680: Add comments explaning variables in action table generation (NFC)

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 28 18:29:29 PDT 2018


aheejin created this revision.
aheejin added reviewers: rnk, majnemer.
Herald added a subscriber: llvm-commits.

It was not easy to understand the meanings of those variables at first.
I guess a bit of comments will help future readers.


Repository:
  rL LLVM

https://reviews.llvm.org/D52680

Files:
  lib/CodeGen/AsmPrinter/EHStreamer.cpp


Index: lib/CodeGen/AsmPrinter/EHStreamer.cpp
===================================================================
--- lib/CodeGen/AsmPrinter/EHStreamer.cpp
+++ lib/CodeGen/AsmPrinter/EHStreamer.cpp
@@ -98,6 +98,11 @@
 
   FirstActions.reserve(LandingPads.size());
 
+  // SizeActions: size of all action entries for a function
+  // SizeSiteActions: size of all action entries for one landing pad
+  // SizeAction: size of an action entry (usually 2, size of typeid + size of
+  //             next action)
+  // SizeTypeID: size of typeid (usually 1)
   int FirstAction = 0;
   unsigned SizeActions = 0;
   const LandingPadInfo *PrevLPI = nullptr;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52680.167576.patch
Type: text/x-patch
Size: 648 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180929/846a837c/attachment.bin>


More information about the llvm-commits mailing list