[PATCH] D52324: [ValueTracking] Allow select patterns to work on vectors in more places

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 25 17:44:42 PDT 2018


tlively added inline comments.


================
Comment at: unittests/Analysis/ValueTrackingTest.cpp:102
+      "}\n");
+  expectPattern({SPF_UNKNOWN, SPNB_NA, false});
+}
----------------
aheejin wrote:
> Why can't this be determined? (1-2 line comment will be good too)
The `0x7ff8000000000000` value is a NaN, so if the second lane behaves like fminnum while the other lanes behave like fminnan. Will add a comment.


Repository:
  rL LLVM

https://reviews.llvm.org/D52324





More information about the llvm-commits mailing list