[PATCH] D52324: [ValueTracking] Allow select patterns to work on vectors in more places

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added a comment.

Do we need to handle integer vectors too?



================
Comment at: unittests/Analysis/ValueTrackingTest.cpp:102
+      "}\n");
+  expectPattern({SPF_UNKNOWN, SPNB_NA, false});
+}
----------------
Why can't this be determined? (1-2 line comment will be good too)


================
Comment at: unittests/Analysis/ValueTrackingTest.cpp:115
+  expectPattern({SPF_UNKNOWN, SPNB_NA, false});
+}
+
----------------
aheejin wrote:
> Could you add some comments for the tests about what each test is testing?
Nit: can we move these tests so they go after the scalar tests? Currently these are between `SimpleFMin` and `SimpleFMax`.


Repository:
  rL LLVM

https://reviews.llvm.org/D52324