[PATCH] D50136: [AArch64] - Return address signing dwarf support

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

thegameg added inline comments.


================
Comment at: test/CodeGen/MIR/AArch64/return-address-signing.mir:12
+  
+  attributes #0 = { noinline nounwind optnone "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "sign-return-address"="all" "sign-return-address-key"="a_key" "stack-protector-buffer-size"="8" "target-cpu"="generic" "target-features"="+neon,+v8.3a" "unsafe-fp-math"="false" "use-soft-float"="false" }
+  
----------------
Are all the attributes needed here? I assume only the sign-* are.


================
Comment at: test/CodeGen/MIR/AArch64/return-address-signing.mir:48
+  savePoint:       ''
+  restorePoint:    ''
+fixedStack:      
----------------
A lot of these are not needed here. In order to dump the MIR file you can use `-simplify-mir` with `-stop-before` or `-stop-after` to skip all the default values.


https://reviews.llvm.org/D50136