[PATCH] D50136: [AArch64] - Return address signing dwarf support

[Luke Cheeseman via Phabricator via llvm-commits]

LukeCheeseman marked 2 inline comments as done.
LukeCheeseman added inline comments.


================
Comment at: include/llvm/BinaryFormat/Dwarf.def:841
+HANDLE_DW_CFA_PRED(0x2d, GNU_window_save, SELECT_SPARC64)
+HANDLE_DW_CFA_PRED(0x2d, AARCH64_negate_ra_state, SELECT_AARCH64)
+HANDLE_DW_CFA_PRED(0x2e, GNU_args_size, SELECT_X86)
----------------
JDevlieghere wrote:
> It doesn't seem right that these two predicates have the same ID? 
The two directives are provided by two different vendors. Although it makes selecting the correct one for dumping require more information, I think this is legal based on the DWARF standard. This is also the encoding used for the GNU patch that provides the same functionality (see https://github.com/gcc-mirror/gcc/blob/f47edbb56126b7e8564f22b0b9d55565a995b7f0/include/dwarf2.def)


https://reviews.llvm.org/D50136